Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-22802: Changes requested by the DRAGONS team #76

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

timj
Copy link
Member

@timj timj commented Jun 16, 2022

This is a rebased version of #44 . It's slightly different than before because python 2 is no longer supported and the code was reformatted with black. The OrderedDict usage was dropped since dict is now ordered and I also protect the AstroData import.

Obvious things we need to think about:

  • How do we make the AstroData supported type something that a user can add without it being hard-coded? Knowing that AstroData.filename should be used seems wrong so we may need to think about whether __str__ can be used or if we have a method that a new type must support.
  • The python/lsst -> DRAGONS file name mangling.

cc/ @chris-simpson

@timj timj mentioned this pull request Jun 16, 2022
@timj
Copy link
Member Author

timj commented Jun 28, 2022

@chris-simpson / @KathleenLabrie what is your current status regarding pex_config usage? Have you made additional changes since this PR was made? Have you stopped using it?

@chris-simpson
Copy link

We're still using a fork. I've make a few more changes I'd have to dig out. Some are associated with our command-line usage (for example, having ListField accept and parse a comma-separated string).

@timj
Copy link
Member Author

timj commented Sep 27, 2023

@ktlim I've had a go at rebasing this again.

@timj timj force-pushed the tickets/DM-22802 branch from a0f71e7 to 9966481 Compare November 5, 2024 22:57
@timj timj requested a review from natelust November 5, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants