Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure conditions object resets if mjd is changed #353

Merged
merged 2 commits into from
Aug 26, 2023
Merged

make sure conditions object resets if mjd is changed #353

merged 2 commits into from
Aug 26, 2023

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Aug 25, 2023

Also get rid of a few number deprecation warnings and isort things.

@yoachim yoachim requested a review from ehneilsen August 25, 2023 21:48
ehneilsen
ehneilsen approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@ehneilsen ehneilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. This way, at least, if someone resets the mjd and then tries using it without updating everything they need to, there should be an error of one sort on another.
There may also be value in adding a warning if the mjd setter gets called.

@yoachim yoachim merged commit 3f6f0fd into main Aug 26, 2023
4 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1067 branch November 1, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehneilsen ehneilsen ehneilsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoachim @ehneilsen