supress wavelength sampling warning for twilight sky #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhiannonlynne
requested changes
Aug 30, 2023
| ) | ||
| bp_temp = Bandpass() | ||
| bp_temp.set_bandpass(bpdata["wave"], bpdata["through"]) | ||
| canon_filters[filter_name] = bp_temp |
There was a problem hiding this comment.
Does this produce the same results as previously, given that the wavelengths were previously on the grid?
There was a problem hiding this comment.
Looks like differences are at the 1e-3 level. But we can resample the bandpass for good measure since it only happens once on init.
rhiannonlynne
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.