Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap astropy for palpy #391

Merged
merged 1 commit into from
Feb 14, 2024
Merged

swap astropy for palpy #391

merged 1 commit into from
Feb 14, 2024

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Feb 14, 2024

Remove last palpy dependency and use astropy for computing parallax factor.

@rhiannonlynne
Copy link
Member

Hi Peter, looks like GitHub is doing something unhappy about the caching again, which I will have a look at. Meanwhile, I'm assuming you ran this locally and it is fine? The results compare the same with palpy compared to astropy?
Might be reasonable to drop in the PR a comparison of the calculation results with astropy versus palpy.

@yoachim
Copy link
Member Author

yoachim commented Feb 14, 2024

image
Comparing this branch to main. Looks close enough to me!

@yoachim yoachim merged commit 16ecc04 into main Feb 14, 2024
4 of 9 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1103 branch March 5, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants