refactor(nx-python): improve regex usage and optional chaining in dep…

…endency handling
lucasvieirasilva · Dec 13, 2024 · 09694fd · 09694fd
1 parent 3225f7a
commit 09694fd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/nx-python/src/generators/uv-project/generator.ts b/packages/nx-python/src/generators/uv-project/generator.ts
@@ -224,7 +224,7 @@ function addTestDependencies(
 ) {
   const newDependencies = [...dependencies];
   const dependencyNames = dependencies
-    .map((dep) => dep.match(/^[a-zA-Z0-9-]+/)?.[0])
+    .map((dep) => /^[a-zA-Z0-9-]+/.exec(dep)?.[0])
     .filter((d) => !!d);
 
   if (

diff --git a/packages/nx-python/src/provider/poetry/utils.ts b/packages/nx-python/src/provider/poetry/utils.ts
@@ -29,7 +29,7 @@ export async function getPoetryVersion() {
   }
   const versionRegex = /version (\d+\.\d+\.\d+)/;
   const match = result.stdout.toString().trim().match(versionRegex);
-  const version = match && match[1];
+  const version = match?.[1];
   return version;
 }
 

diff --git a/packages/nx-python/src/provider/uv/provider.ts b/packages/nx-python/src/provider/uv/provider.ts
@@ -482,7 +482,7 @@ export class UVProvider implements IProvider {
           ? packageMetadata?.['requires-dist']?.[dep]
           : packageMetadata?.['requires-dev']?.[category]?.[dep];
 
-      if (!depMetadata || !depMetadata.editable) {
+      if (!depMetadata?.editable) {
         continue;
       }