Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-python): relock root when changing deps on grouped projects #195

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

kylebjordahl
Copy link
Contributor

Current Behavior

add does not relock root when project is grouped in root pyproject

Expected Behavior

add (and other like operators) should always relock the root

Related Issue(s)

Fixes #194

Copy link
Owner

@lucasvieirasilva lucasvieirasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylebjordahl for raising this PR, lgtm

@lucasvieirasilva lucasvieirasilva merged commit 3fdd0cb into lucasvieirasilva:main Mar 27, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
## [18.0.1](nx-python-v18.0.0...nx-python-v18.0.1) (2024-03-27)

### Bug Fixes

* **nx-python:** relock root when changing deps on grouped projects ([#195](#195)) ([3fdd0cb](3fdd0cb))
Copy link

🎉 This PR is included in version 18.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kylebjordahl kylebjordahl deleted the issue-194 branch March 27, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add executor does not update root lock if project is in dependency group
2 participants