feat(nx-python): add support for nx releases #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasvieirasilva
force-pushed
the
nx-release
branch
from
7414669
to
0b3ef52
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
# [19.1.0](nx-python-v19.0.2...nx-python-v19.1.0) (2024-09-18) ### Features * **nx-python:** add support for nx releases ([#246](#246)) ([9614843](9614843))
|
🎉 This PR is included in version 19.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@lucasvieirasilva Let's stay in touch about this, I have an update to versioning coming which will require a tiny amount of python specific code on top from you instead of this massive amount of duplication. Are you on the community discord? You can DM me there |
|
@JamesHenry, thanks for letting me know, great, I pretty much duplicated a bunch of stuff from the official Nx release code and changed the Python specifics. Yes, I am in the community discord, I'll keep watching the Nx releases, and once you guys have this update, we can talk again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Nx releases
Current Behavior
All the current features should work as-is.
Expected Behavior
Adds support for Nx release commands.
Related Issue(s)
Re #122
Additional notes
SonarQube is raising a bunch of comments that I won't address because I want this implementation to be as closed as possible with the
@nx/jsimplementation (once they make the releases more modular, I can refactor those files)