fix(nx-python): remove deprecated property and replace with context.projectsConfigurations
#249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.projectsConfigurations`
Cammisuli
changed the title
context.projectsConfigurationscontext.projectsConfigurations
|
Hi @Cammisuli thanks for the contribution, I really appreciate it, I've noticed some Unit test failures in the PR, could you pls check? Thanks! |
|
my bad! I pushed an update to fix the tests 🙂 |
lucasvieirasilva
approved these changes
Oct 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
## [19.1.3](nx-python-v19.1.2...nx-python-v19.1.3) (2024-10-07) ### Bug Fixes * **nx-python:** remove deprecated property and replace with `context.projectsConfigurations` ([#249](#249)) ([c920a62](c920a62))
|
🎉 This PR is included in version 19.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
First off, thank you for maintaining the python plugin for Nx. :) While doing some testing with the latest version of Nx, we found that this plugin does not work properly. This requires some changes because we removed a deprecated property from
context. I've updated the references I found in this PR now.Let me know if you have any questions or concerns, thanks!
Current Behavior
Running this plugin with Nx 20 throws errors because of use of removed property on context.
Expected Behavior
Replaced
context.workspacewithcontext.projectsConfigurationswhich should be available since Nx 17.Related Issue(s)
Fixes #