Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added bubbles icon #2582

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

vqh2602
Copy link

@vqh2602 vqh2602 commented Nov 4, 2024

What is the purpose of this pull request?

  • New Icon

Description

Added new bubbles icon.

Icon use case

Use in leisure activities or weather

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @vqh2602
  • I've based them on the following Lucide icons: bubbles
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Added or changed icons

icons/bubbles.svg

Preview cohesion icons/square-asterisk.svg
icons/bubbles.svg
icons/banknote.svg
Preview stroke widths icons/bubbles.svg
icons/bubbles.svg
icons/bubbles.svg
DPI Preview (24px) icons/bubbles.svg
Icon X-rays icons/bubbles.svg
Icon Diffs icons/bubbles.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BubblesIcon = createLucideIcon('Bubbles', [
  ["path",{"d":"M7.2 14.8a2 2 0 0 1 2 2"}],
  ["circle",{"cx":"18.5","cy":"8.5","r":"3.5"}],
  ["circle",{"cx":"7.5","cy":"16.5","r":"5.5"}],
  ["circle",{"cx":"7.5","cy":"4.5","r":"2.5"}]
])

@jguddas
Copy link
Member

jguddas commented Nov 4, 2024

1px gap violation in the bubble with the shine arc.

@vqh2602
Copy link
Author

vqh2602 commented Nov 7, 2024

1px gap violation in the bubble with the shine arc.

corrected

@jguddas
Copy link
Member

jguddas commented Nov 7, 2024

1px gap violation in the bubble with the shine arc.

corrected

There is still some overlap.

Something like this would work:
icons
Open lucide studio

@vqh2602
Copy link
Author

vqh2602 commented Nov 8, 2024

1px gap violation in the bubble with the shine arc.

corrected

There is still some overlap.

Something like this would work: iconsOpen lucide studio

Completed according to contributions

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants