-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): Add cloud-check
icon
#2612
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const CloudCheckIcon = createLucideIcon('CloudCheck', [
["path",{"d":"m17 14-5.5 5.5L9 17"}],
["path",{"d":"M5 16.743A7 7 0 1 1 15.71 9h1.79a4.5 4.5 0 0 1 1.5 8.742"}]
]) |
cf63755
to
b460160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
It's moved one pixel up to make it visually centered by compensating for the "heavy bottom". Otherwise, it looks a bit low when centered next to text. |
That will make it twitch when used in a toggle state 😢 |
Hm yeah, the way I'm using the icon right now is with the loader-circle and cloud-alert, so there it works. Here are the groups of icons where the main cloud is aligned:
The question is basically, do we want individual icons centered visually, or should icons always be aligned in the "group" they belong to? The latter would sacrifice visual alignment when the icon is used stand-alone and not next to other icons from the group or as toggle. Either way if we decide to move cloud-check down a pixel, I'd probably also move the cloud-alert icon down a pixel |
Should be aligned with other cloud icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cloud icon should be aligned with the other icons you mentioned from the group.
Consistency is more important than the "visually centered rule" IMO.
closes #2564
closes #2160
What is the purpose of this pull request?
Description
Adds new cloud-check icon
Icon use case
My use case is for a "sync with cloud" feature, where I show the icon similar to how Google Docs does it, when the document is in sync with what is stored on the server.
I can't think of other non-arbitrary use cases, but considering the popularity of Google Docs as well as the two related issues, I'd say this is not particularly niche.
Alternative icon designs
#2564 contains a few other designs. The icon is very similar to those posted there, especially the one from @jguddas but with the checkmark more balanced within the cloud (imo, of course).
I'm using this design for a project, but since there are other designs available as well feel free to close this PR if it doesn't match your expectations.
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting