Recreate Preparation files #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andreas-Piter
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Hi @esrivas17, thanks for your pull request and the implemented changes.
I would like to ask you to apply the following changes:
- address the comments to the code
- fix the coding style according to
make lint(the pipeline failed for this part) - enter your name to the contributors in file "Authors.rst"
- add the issue Recreating files in preparation step #12 to this Pull request.
Comment on lines
+187
to
+193
| coord_utm_obj = CoordinatesUTM(file_path=join(self.path, "coordinates_utm.h5"), logger=self.logger) | ||
| if not exists(coord_utm_obj.file_path) or (exists(coord_utm_obj.file_path) and coord_utm_obj.getShape()[1:] != mean_amp_img.shape): | ||
| coord_utm_obj.prepare(input_path=join(self.config.general.input_path, "geometryRadar.h5")) | ||
| del coord_utm_obj | ||
|
|
||
| if not exists(join(self.path, "background_map.h5")): | ||
| bmap_obj = AmplitudeImage(file_path=join(self.path, "background_map.h5")) | ||
| del coord_utm_obj | ||
| bmap_obj = AmplitudeImage(file_path=join(self.path, "background_map.h5")) | ||
| if not exists(bmap_obj.file_path) or (exists(bmap_obj.file_path) and bmap_obj.getShape() != mean_amp_img.shape): |
There was a problem hiding this comment.
I think we can keep it even simpler. Let's store the amplitude image and the coordinates every time as it is not the computational bottleneck. It is enough to remove the if statement.
Comment on lines
+106
to
+109
| def getShape(self): | ||
| with h5py.File(self.file_path, 'r') as f: | ||
| return f["background_map"].shape | ||
|
|
There was a problem hiding this comment.
I think we don't need this part.
Comment on lines
+204
to
+206
| def getShape(self): | ||
| with h5py.File(self.file_path, 'r') as f: | ||
| return f["coord_utm"].shape |
There was a problem hiding this comment.
I think we don't need this part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am trying to recreate
coordinates_utm.h5andbackground_map.h5in the case of a second run with different inputs dimensions.