Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tags to theme.toml. #934

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonhollingshead
Copy link
Contributor

@simonhollingshead simonhollingshead commented Oct 18, 2024

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

When I was looking through the hugo themes site to attempt to give a friend a link to this theme, I went into the "dark" tag on the right hand side... and realised Coder wasn't there. Looking closer, I noticed that coder doesn't claim to be light or dark (nor "Dark mode" which is also in the sidebar for some reason). All three seemed entirely appropriate for this theme to claim.

Compare this to https://themes.gohugo.io/themes/hugo-papermod/ or https://themes.gohugo.io/themes/hugo-theme-hello-friend-ng/ or https://themes.gohugo.io/themes/gokarna/ - all of these have both the "light" and the "dark" tag to reflect that they're toggleable. The tags aren't used in a mutually exclusive way.

As such, for coder's discovery, I think it should also be in both sections.

I'm not sure if changing this is all that is needed (and then it would naturally propagate) or whether additional changes are needed in an official Hugo repo too, but I wouldn't have the authority to make such changes elsewhere on your behalf anyway, so I just changed the TOML file from this repo.

Issues Resolved

No issues filed are fixed.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already

@simonhollingshead simonhollingshead marked this pull request as ready for review October 18, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant