Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to hide batch file generator on Vihko #567

Open
mikkohei13 opened this issue Oct 3, 2024 · 4 comments · May be fixed by #669
Open

Add option to hide batch file generator on Vihko #567

mikkohei13 opened this issue Oct 3, 2024 · 4 comments · May be fixed by #669
Assignees
@olzraiti
Labels
quick Takes less than one day to complete
Milestone
Release 78

Comments

@mikkohei13
Copy link
Member

Vihko form option to hide batch file generator when import is allowed.

By default generator should be open when import is allowed: this is how other forms should work.
@wkmor1 wkmor1 added the quick Takes less than one day to complete label Oct 7, 2024
@wkmor1 wkmor1 added this to the Release 78 milestone Oct 14, 2024
@wkmor1 wkmor1 changed the title Vihko option to hide batch file generator Add option to hide batch file generator on Vihko Oct 23, 2024
olzraiti added a commit that referenced this issue Nov 5, 2024
@olzraiti
implement MHL.allowExcelGeneration [#567]
2bf5ffb
@olzraiti olzraiti linked a pull request Nov 5, 2024 that will close this issue
Open
@olzraiti
Copy link
Member

olzraiti commented Nov 5, 2024

@mikkohei13 testable in http://567.dev.laji.fi/project/MHL.1136/about

@mikkohei13
Copy link
Member Author

  • Sidebar does not show link to ./generate -> ok
  • ./generate page does now work: buttons are disabled. -> should work, if user manually enter the url of this page. Or optionally only for admins.
  • When user not logged in, the ./about page gives Hups-warking and error on console:

Image

@olzraiti
Copy link
Member

I updated it to work so that:

  • sidebar generate page is shown if user is form admin
  • generate page works if used is form admin

So admin bypasses the option that prevents the generate tool.

When user not logged in, the ./about page gives Hups-warking and error on console:

Couldn't repro, maybe already fixed and unrelated to this task?

@mikkohei13
Copy link
Member Author

Thanks, no error anymore. Note if someone reads this later: non-admins can access /generate -page, but the form is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olzraiti olzraiti

Labels
quick Takes less than one day to complete
Projects
None yet
Milestone
Release 78
Development

Successfully merging a pull request may close this issue.

Implement MHL.allowExcelGeneration [closes #567] luomus/laji
3 participants
@mikkohei13 @wkmor1 @olzraiti