Don't trim mailto: prefix when converting a Uri into a string #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine with me. Apologies if this caused any inconvenience. |
|
No problem 👍 just had to temporarily work around the removal by prefixing it with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1436
So actually I think it's never necessary to remove the
mailto:prefix. @mre tell me if you disagree. I assume that this was done for cosmetic purposes in the CLI output. But I even prefer to keep the scheme in the CLI output since it feels more correct and terminal emulators then detect the address as correct URL so that you can click on it to send a mail to that address using your email application. (noticed in Alacritty)