Fix: Windows drive paths misidentified as URLs

[toadslop]

Attempts to fix this issue.

This has resulted in some failing tests on Linux. Will revise.

Edit:

Fixed Linux tests. Let me know if you have any suggestions for improvement.

[mre]

Good job! Just a minor ask before we can merge this.

[toadslop]

I made an adjustment to be more explicit. Relying on the behavior of RequestBuilder hides the intent a bit, so instead I explicitly say that I'm rejecting Urls that don't have an http (or https) scheme.

I also adjusted the last part of the function to handle Windows behavior better. The function originally assumed that missing a scheme could have been a mistake and adds https, but on Windows this can never happen because the separators in Windows filepaths are not valid for Urls.

Finally, I added some Windows-only tests to validate that the behavior is correct.

[toadslop]

After the changes, though, some tests are failing that don't fail on Windows. I will need to investigate to understand the errors. They're related to something called "wayback", which I have never heard of and so I have no idea what the behavior is supposed to be.

[mre]

Oh, the wayback you're referring to is short for "wayback machine", which we use to suggest archived versions in case of broken links. Unfortunately, their API is pretty flaky and lookups randomly fail, which makes these tests unreliable as well.

I suggest to ignore these particular errors for the moment. Perhaps we can even disable them entirely.

[toadslop]

Yup, looks like you're right. I forced a test rerun and it passed.

[mre]

I cleaned up the PR a bit. I think it's ready to be shipped.
Thanks for your contribution @toadslop. 😊

[mre]

This is now released!