test: fail when interpreting md footnote as link #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomas-zahner, what do you think? I followed your advice and parsed the plaintext if |
|
I went ahead and merged this. The tests pass and the changes just extended the existing logic. If we find a bug with it, we can easily fix it in-place. |
|
Ah that looks good, thanks for the implementation 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #1409.
Accidentally closed #1410 by rebasing on top of master, then pushing mid-rebase and don't have permissions to push there. 😅 So reopening here.
@jan-ferdinand fyi
The underlying issue is still not fixed. Just rebased.
@thomas-zahner let me know if you're still looking into this one.