-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated: Add partial view of prev and next slide #167
base: master
Are you sure you want to change the base?
Conversation
Add the documentation support for partial option
fix documentation
Good job and thanks for your contribution. 👍 I think that allowing the If you have time to make that happen, that will be great 😄 |
Hi @lyfeyaj Now the |
Thanks @intizarahmad for this useful feature. Still I have one case where I only want to display a part of the next slide, but not the previous one. |
Hi @ltoussaint, I am glad you found this useful. |
if (!browser.transitions) { | ||
element.style[slideDir] = (index * -width) + 'px'; | ||
} | ||
|
||
container.style.visibility = 'visible'; | ||
|
||
console.log('slidePos', slidePos) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove console.log
from source code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
swipe.js
Outdated
@@ -713,6 +814,7 @@ | |||
} | |||
|
|||
function move(index, dist, speed) { | |||
console.log({index, dist, speed}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove console.log
from source code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
swipe.js
Outdated
|
||
/** | ||
* Setting up defaul partial Width if partial defined but erither its boolean | ||
* of the partial does not seems to be in range of .01 to .20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found several typos in above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing, I have corrected the typos
Hi @intizarahmad, I was fully tested features of
Video.record.2022-02-14.11.45.01.mov
Hoping these two strange behaviors can be fixed ^_^ |
Hi @lyfeyaj,
I took the reference of #2 and fixed few issues:
partial
option will support from two slides.continuous
option isfalse
the previous and next slides will not be shown if we are on first and last slide respectively.Here is the demo
Thanks