[WIP]native sidecar pod status #3144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murongl-lyft
changed the title
murongl-lyft
changed the title
| initializing := false | ||
| initContainerCount := 0 | ||
| for i := range pod.Status.InitContainerStatuses { |
There was a problem hiding this comment.
One goal of showing initializing containers can be - show customers that their application container run is waiting on initializing of platform containers.
So i would think it would be really nice to include the sidecar containers in this information, since now they are all in initContainers.
- normal init container -- make sure it's terminated and exit code is 0
- sidecar init container -- make sure it's running and ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to get the correct Pod status with native sidecars.
Description
Testing Performed
GitHub Issue
Fixes #
TODOs