frontend: Adjust workflow layout whitespace #3155
Merged
+21
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
septum
changed the title
jecr
reviewed
Oct 23, 2024
jecr
reviewed
Oct 23, 2024
| @@ -74,11 +81,11 @@ const WorkflowLayout = ({ | |||
| children, | |||
| }: React.PropsWithChildren<LayoutProps>) => { | |||
| const location = useLocation(); | |||
| const workflowPaths = workflow.routes.map(({ path }) => `/${workflow.path}/${path}`); | |||
| const workflowPaths = workflow?.routes.map(({ path }) => `/${workflow?.path}/${path}`); | |||
There was a problem hiding this comment.
It there is no workflow.path what would be rendered?, could it do with a fallback or other handling?
There was a problem hiding this comment.
I see, because of workflow possibly being undefined.
I think I'm going to change the type signature to reflect that workflow (and the path property) are required.
jecr
reviewed
Oct 23, 2024
| @@ -74,11 +81,11 @@ const WorkflowLayout = ({ | |||
| children, | |||
| }: React.PropsWithChildren<LayoutProps>) => { | |||
| const location = useLocation(); | |||
| const workflowPaths = workflow.routes.map(({ path }) => `/${workflow.path}/${path}`); | |||
| const workflowPaths = workflow?.routes.map(({ path }) => `/${workflow?.path}/${path}`); | |||
There was a problem hiding this comment.
Maybe this in case of no workflow?.routes so workflowPaths is not left undefined
Suggested change
| const workflowPaths = workflow?.routes.map(({ path }) => `/${workflow?.path}/${path}`); | |
| const workflowPaths = workflow?.routes.map(({ path }) => `/${workflow?.path}/${path}`) || []; |
jecr
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Before
After
Testing Performed
Manual