Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 'redirect_options' addition for 'redirect_to' in confirmations #1612

Conversation

kaekasui
Copy link
Contributor

In the following PR, redirect_options was added. However, there was an omission in the confirmation email section when errors occurred, so I have included it.
#1599

Copy link
Collaborator

@MaicolBen MaicolBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why that test is failing, can you take a look and add a spec if you can?

@kaekasui kaekasui force-pushed the add-redirect_to_options-for-confirmations-redirect branch from 767c2f8 to 4c6d4b5 Compare November 8, 2023 12:33
@kaekasui
Copy link
Contributor Author

kaekasui commented Nov 8, 2023

Sorry for not noticing! After performing a 'rebase master', it looks like the tests have passed.

@MaicolBen MaicolBen merged commit d4deea1 into lynndylanhurley:master Nov 10, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants