Wrap System.load and System.loadLibrary calls with doPrivileged. #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mulugeta Mammo <[email protected]>
5 tasks
berghov1941
approved these changes
May 6, 2023
berghov1941
reviewed
May 6, 2023
There was a problem hiding this comment.
src/java/net/jpountz/util/Native.java
berghov1941
approved these changes
May 6, 2023
|
@odaira Can you please review/merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where pluggable modules are in use and Java security permissions are applied, such as in OpenSearch, wrapping the
System.loadandSystem.loadLibrarycalls withAccessController.doPrivilegedresolves access control exceptions thrown by plugins that are granted access to load a native library. This PR does that.This PR is motivated by a feature request to add lz4-java and zstd-jni compressions to OpenSearch. The zstd-jni equivalent of this PR is available here.
Signed-off-by: Mulugeta Mammo [email protected]