Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --word_timestamps flag for better syncing #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davejab
Copy link

@davejab davejab commented Jun 7, 2024

Based on this discussion: openai/whisper#1888

Sync accuracy is greatly improved by setting the --word_timestamps True.

Usage:

auto_subtitle video.mkv --word_timestamps True

Possible fix for #28 and #37

Copy link

what-the-diff bot commented Jun 7, 2024

PR Summary

  • Introduction of New Command Line Argument
    A new functionality has been added that allows the user to include additional command when running this tool. This additional option --word_timestamps is implemented to provide more detailed results. It specifically caters towards extracting precise timings for individual words appearing within the data stream, enhancing the accuracy of output information.

@starptr
Copy link

starptr commented Sep 9, 2024

Hi, did you end up implementing this feature? This PR's diff only shows adding a new CLI option

@zaltinsoy
Copy link

Hi, did you end up implementing this feature? This PR's diff only shows adding a new CLI option

This feature is already implemented in the current PR. The new CLI option (--word_timestamps) is passed to Whisper as input, and since it's already defined within Whisper, no further changes are needed. I made a fork to implement this and some other pending PRs.

@starptr
Copy link

starptr commented Sep 11, 2024

Oh awesome, I thought that perhaps whisper's output format changes so the srt generation needed to change but it does not. Your fork seems great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants