Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: using sklearn.utils for creating RNGs and generating minibatches #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dohmatob
Copy link

Spotlight already depends on scikit learn (sklearn), so we could delegate even more stuff to the later.

@dohmatob dohmatob changed the title ENH: using sklearn.utils for create RNGs and generating minibatches ENH: using sklearn.utils for creating RNGs and generating minibatches Mar 13, 2018
@maciejkula
Copy link
Owner

Looks good, thanks for the contribution!

Could you fix the flake8 issue please?

@dohmatob
Copy link
Author

Fixed the flake issue. Now there is a mystical failure which seems to be affecting other open PRs too.

UnsatisfiableError: The following specifications were found to be in conflict:
  - chardet -> python[version='>=3.6,<3.7.0a0']
  - python=2.7
Use "conda info <package>" to see the dependencies for each package.

@maciejkula
Copy link
Owner

Yes, the dependencies seem to have moved in an annoying way. I'll do my best to resolve this.

@maciejkula
Copy link
Owner

Could you please rebase on top of newest master?

@maciejkula
Copy link
Owner

Can you rebase please? Otherwise I'll close this and re-open the PR with rebased code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants