Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements #123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jilljenn
Copy link

Are you interested in a requirements.txt file for people who do not care about conda? 😄

@maciejkula
Copy link
Owner

Thanks! What about PyTorch in requirements?

@jilljenn
Copy link
Author

PyTorch is a pain in the .ass (file?) to install via pip, mainly because you need a separate egg for each Linux distribution/version. So, I don't know. Maybe at least it will work for Mac users. Let's discriminate.

By the way, I pinged you on Twitter with questions 😁

@maciejkula
Copy link
Owner

Hey @jilljenn can you make an issue here on Github with your question?

@artdgn
Copy link

artdgn commented Oct 30, 2018

@jilljenn why is installing from pip such a pain, from what I see from pytorch docs it's just pip3 install torch torchvision. It seems to work ok for me. Are there any issues with such in an installation?

@rth
Copy link
Contributor

rth commented Jan 23, 2019

Ideally, once #81 is resolved, it could be just,

pip install pytorch

and pull the right dependencies (assuming this plays well in combination with conda).

Also though venv is useful, from what I see packages usually suggest to install something with just pip install ... leaving up to the user whether they want to use a virtualenv or not.

mit456 pushed a commit to mit456/spotlight that referenced this pull request Apr 2, 2020
Process to follow:
1. Install spotlight using virtualenv PR: maciejkula#123
2. run python setpy.py install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants