Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support overwrite status #766

Merged
merged 3 commits into from
Oct 19, 2023
Merged

support overwrite status #766

merged 3 commits into from
Oct 19, 2023

Conversation

yseto
Copy link
Contributor

@yseto yseto commented Sep 13, 2023

No description provided.

@yseto yseto self-assigned this Sep 13, 2023
@yseto yseto force-pushed the as-status branch 4 times, most recently from e44259e to 078d4e9 Compare October 16, 2023 08:32
@yseto yseto marked this pull request as ready for review October 17, 2023 01:29
lufia
lufia reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@lufia lufia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to update README.md

lufia
lufia approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@lufia lufia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status is one of ok, warning, critical or unknown.

@yseto yseto merged commit c93dad2 into master Oct 19, 2023
16 checks passed
@yseto yseto deleted the as-status branch October 19, 2023 01:10
@yseto
Copy link
Contributor Author

yseto commented Oct 19, 2023

Thanks for your review.

@mackerelbot mackerelbot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lufia lufia lufia approved these changes

Assignees

@yseto yseto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yseto @lufia