Skip to content

Commit

Permalink
Re-enable hfscompression for non-root installs
Browse files Browse the repository at this point in the history
The bug that necessitated this was fixed in libarchive 3.4.0.

See: https://trac.macports.org/ticket/56563
  • Loading branch information
jmroot committed Aug 30, 2019
1 parent 50f2934 commit 5346aa8
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/registry2.0/portimage.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -353,8 +353,7 @@ proc extract_archive_to_tmpdir {location} {
global macports::hfscompression
# Opportunistic HFS compression. bsdtar will automatically
# disable this if filesystem does not support compression.
# Have to be root due to <https://trac.macports.org/ticket/56563>.
if {${macports::hfscompression} && [getuid] == 0 &&
if {${macports::hfscompression} &&
![catch {macports::binaryInPath bsdtar}] &&
![catch {exec bsdtar -x --hfsCompression < /dev/null >& /dev/null}]} {
ui_debug "Using bsdtar with HFS+ compression (if valid)"
Expand Down

0 comments on commit 5346aa8

Please sign in to comment.