Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeRDP: Update to 3.9.5; fix build on Sequoia #27098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielO
Copy link
Contributor

@DanielO DanielO commented Dec 16, 2024

Description

FreeRDP's Mac code uses deprecated APIs which have been removed in Sequoia, so switch to X11 backend. Update to latest version while here.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.1.1 24B91 x86_64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

FreeRDP's Mac code uses deprecated APIs which have been removed in
Sequoia, so switch to X11 backend.

Closes: https://trac.macports.org/ticket/71458
@mohd-akram
Copy link
Member

mohd-akram commented Dec 16, 2024

The latest version currently is 3.10.1. See if that resolves the issue without switching to X11. If it doesn't, using macosx_deployment_target like in 84b03ef might help in fixing the deprecated API issue. If that doesn't work, you can post the error here when building 3.10.1.

@DanielO
Copy link
Contributor Author

DanielO commented Dec 16, 2024

There is no fix for the broken native client, see FreeRDP/FreeRDP#10558

installing the X11 and/or SDL clients are the suggested work around for now.

I tried 3.10.0 but I get..

:info:configure CMake Error at /opt/local/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
:info:configure   Could NOT find FFmpeg (missing: _FFmpeg_FOUND_LIBRARIES AVUTIL_LIBRARIES
:info:configure   AVUTIL_INCLUDE_DIRS AVUTIL_FOUND AVCODEC_LIBRARIES AVCODEC_INCLUDE_DIRS
:info:configure   AVCODEC_FOUND AVUTIL AVCODEC)

I haven't worked out why yet.
3.9.0 (not 3.9.5 like I put in the commit log..) does work in my limited testing.

@mascguy mascguy changed the title Fix build on Sequoia and update to 3.9.5 FreeRDP: Update to 3.9.5; fix build on Sequoia Dec 16, 2024
@ryandesign
Copy link
Contributor

There is no fix for the broken native client, see FreeRDP/FreeRDP#10558

You have tried setting the deployment target to 14 as suggested? This is the recommended recipe to do that:

https://trac.macports.org/wiki/SequoiaProblems#ScreenCaptureKitRequirementwithmacOS15SDK

I tried 3.10.0 but I get..

:info:configure CMake Error at /opt/local/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
:info:configure   Could NOT find FFmpeg (missing: _FFmpeg_FOUND_LIBRARIES AVUTIL_LIBRARIES
:info:configure   AVUTIL_INCLUDE_DIRS AVUTIL_FOUND AVCODEC_LIBRARIES AVCODEC_INCLUDE_DIRS
:info:configure   AVCODEC_FOUND AVUTIL AVCODEC)

I haven't worked out why yet. 3.9.0 (not 3.9.5 like I put in the commit log..) does work in my limited testing.

The same error causes the builds of 3.9.0 to fail here in CI.

@ryandesign
Copy link
Contributor

The commit message does not begin with the portname, colon, and space, and the version number in the commit message should be corrected. If not changed beforehand, we can fix it when we merge the PR by using the "Squash and merge" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants