Fix image caption text contrast #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the colour of caption text to Base Light to provide more contrast with the dark background.
✅ Deploy Preview for eleventy-excellent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @madrilene , I recently started using your template and noticed that image captions don't have enough contrast with the backdrop when maximized. I fixed the issue in my website and wanted to contribute back here. |
|
Ah ok, I'll look into that! We have to modify that still, as now the caption disappears in light mode on regular images. |
|
@madrilene could you point me to a page where I can reproduce the text disappearing in light mode? I tried to search for it but couldn't find one, even in light mode it seems that the backdrop is always dark enough to go well with |
|
Sure! The regular caption is here (not within a dialog)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the colour of caption text to Base Light to provide more contrast with the dark background.