Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metal Performance Shaders #591

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tbetcke
Copy link

@tbetcke tbetcke commented Mar 17, 2024

Hi,

this is a draft pull request to add Metal Performance Shaders.

I am trying to add the MetalPerformanceShaders framework. I have followed some other PRs in how to add frameworks.
But when I am running cargo run --bin header-translator I am getting the error message

─ERROR unknown unexposed attribute, name="MPS_ENUM_AVAILABLE_STARTING", fnlike=true

How do I update the libraries to deal with this? My progress so far is visible in this pull request.

@tbetcke tbetcke marked this pull request as draft March 17, 2024 21:24
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for beginning on this!

I am getting the error message [...]

You probably have to update something in header-translator/src/unexposed_attr.rs, close to the other availability macros.


Additionally, for the header translator to work, you have to create a fork of https://github.com/madsmtm/icrate-generated, commit the generated changes to that, and update the Git submodule in this PR to point to the commit in your fork (no need to create a PR to the repo).

macos = "13.0"
maccatalyst = "16.0"
ios = "16.0"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing value for tvos.

@madsmtm
Copy link
Owner

madsmtm commented May 18, 2024

One troublesome thing about MPS is that it's actually an umbrella framework containing many smaller (private) frameworks. In 03d7a74, I added preliminary support for this, though I think more work is still needed for this to work fully.

See also #640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants