Restores backwards compatibility with TinyMCE plugins again (after it…

[hostep]

… broke with introduction of TinyMCE7).

Description (*)

Magento comes with 2 new TinyMCE plugins by default:

• magentowidget
• magentovariable

Recently, with the switch from TinyMCE v5 to v7 in the latest security patch releases (2.4.7-p3, ...) and 2.4.8-beta1, those plugins got rewritten to adhere to the new system in TinyMCE 7. However, a big mistake was made by not returning the widgets as an object, which meant that you couldn't call the functions defined inside the plugin anymore when trying to use the widget from another location.

Example with magentowidget, old version vs new version, note that in the new version there is no object being returned in that magentowidget function anymore.

This resulted in this error output when trying to call the encodeWidgets on the magentowidget instance, because that last one was just an empty object:

TypeError: tinymce.activeEditor.plugins.magentowidget.encodeWidgets is not a function

This PR fixes that.

Related Pull Requests

Fixed Issues (if relevant)

1. Doesn't appear to be working anymore with TinyMCE 7 Magenerds/PageDesigner#54

Manual testing scenarios (*)

1. Setup Magento 2.4.7-p2 without magento's pagebuilder
2. Install https://github.com/Magenerds/PageDesigner
3. In the backoffice, create a new cms page, using the pagedesigner interface
4. save the page
5. now upgrade to Magento 2.4.7-p3 (still without magento's pagebuilder)
6. Return to the backoffice, and start editing that new page created in step 4
7. Open the 'content' tab and see if the pagedesigner interface is loading the content, also take a look at your browsers inspector.

That last step will fail and you'll see an error in your browser's console. This PR fixes this issue.

Questions or comments

Adding automated tests for this will be hard, so I'm not doing it, hopefully that's okay, if not, please write them yourselves, I won't have the time to put into this task.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Restores backwards compatibility with TinyMCE plugins again (after it… #39262: Restores backwards compatibility with TinyMCE plugins again (after it…

[m2-assistant]

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

@magento run all tests

[hostep]

@magento run Unit Tests

[fballiano]

TinyMCE7 is GPL, I don't undestand how this update was pushed #39252

[hostep]

Yes yes, that's a completely different issue, and I was already aware of that, please give the legal team of Adobe some time to look into it and they'll get back with an answer hopefully.

[engcom-Hotel]

@magento create issue