Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Report-To' header is deprecated and no longer recommended #39278

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

WaPoNe
Copy link
Contributor

@WaPoNe WaPoNe commented Oct 17, 2024

Description (*)

As reported in this document, 'Report-To' header is deprecated and no longer recommended to report CSP violations.
And, in any case, it is not possible to add "report-to " in the 'Content-Security-Policy-Report-Only' header.

Manual testing scenarios (*)

  1. Set CSP in "report-only"
  2. Compile 'Report URI' fields in Configuration > Security > Content Security Policy (CSP) page
  3. Navigate the website in a page that contains some CSP violations
  4. It must be a POST call to Report URI.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] 'Report-To' header is deprecated and no longer recommended #39288: 'Report-To' header is deprecated and no longer recommended

Copy link

m2-assistant bot commented Oct 17, 2024

Hi @WaPoNe. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@WaPoNe
Copy link
Contributor Author

WaPoNe commented Oct 17, 2024

@magento run all tests

@WaPoNe
Copy link
Contributor Author

WaPoNe commented Oct 18, 2024

In the meantime I've prepared the patch: https://gist.github.com/WaPoNe/f439f59501897f73427c70e9b5d0edaf

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] 'Report-To' header is deprecated and no longer recommended
2 participants