Reduce duplication by introducing WherePredicatesOrBool::from_lit #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse for WherePredicatesOrBool and meta_name_value_2_where_predicates_bool each had a version of this code. I compared each match branch while unifying them, and the two behaviours were identical. This commit introduces an error handling change for literal that's neither a boolean nor a string: previously Parse for WherePredicatesOrBool would feed it to parse_terminated expecting a WherePredicate, which would fail; and meta_name_value_2_where_predicates_bool would pass it through to its general error handler. Now we make a bespoke error for this weird case. (I'm not sure why we have both WherePredicatesOrBool and Bound. I think they could be unified.)
|
This is textually near #22 but the changes don't actually conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse for WherePredicatesOrBoolandmeta_name_value_2_where_predicates_booleach had a version of this code. I compared each match branch while unifying them, and the two behaviours were identical.This commit introduces an error handling change for literal that's neither a boolean nor a string: previously
Parse for WherePredicatesOrBoolwould feed it toparse_terminatedexpecting aWherePredicate, which would fail; andmeta_name_value_2_where_predicates_boolwould pass it through to its general error handler. Now we make a bespoke error for this weird case.(I'm not sure why we have both
WherePredicatesOrBoolandBound. I think they could be unified.)