Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim range3 #2172

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Sim range3 #2172

wants to merge 36 commits into from

Conversation

joshuef
Copy link
Contributor

@joshuef joshuef commented Oct 2, 2024

Description

Please provide a brief description of the changes made in this pull request. Highlight the purpose of the changes and the problem they address.

Related Issue

Fixes #<issue_number> (if applicable).

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

merge the results after we see split record.
Use Quorum::Majority at least (instead of Quorum::One)
this indirectly affects how many close nodes returned and could stymie
the GetRange effectiveness
ie, even if query times out if we have peers, we update

seems like we timeout more due to high K_VALUE
previously we just dropped any attempt at comms there
We were cleaning up bootstrap even if not full just because of being local
… fetched

allow more to be fetched if needed due to distance variation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant