Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests enable register test and windows support #2374

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

ermineJose
Copy link
Contributor

@ermineJose ermineJose commented Nov 4, 2024

Description

adds register checking in vault CLI testcases.

Related Issue

Fixes #<issue_number> (if applicable).

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

@ermineJose ermineJose force-pushed the tests-enable_register_test branch 9 times, most recently from 502c230 to 365ff32 Compare November 5, 2024 15:21
@ermineJose ermineJose changed the title Tests enable register test Tests enable register test and windows support Nov 5, 2024
@ermineJose ermineJose force-pushed the tests-enable_register_test branch 2 times, most recently from b20b3b5 to b5563b9 Compare November 5, 2024 17:01
@ermineJose ermineJose force-pushed the tests-enable_register_test branch 5 times, most recently from 645603a to 0cad33e Compare November 8, 2024 04:46
Comment on lines +507 to +508
NUM_OF_PUBLIC_FILES = find_number_before_word("file_list.txt", "public")
print("NUM_OF_PUBLIC_FILES:", NUM_OF_PUBLIC_FILES)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not directly use rg here instead of using Python?
Assuming the file content is something like the one below, then rg should suffice.

❯ echo "1000 public\n2000 private" | rg '\d+\s+public' | awk '{print $1}'
1000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working and python makes it easier to read from the file and make a comparison operation within the one job in windows.

@ermineJose ermineJose force-pushed the tests-enable_register_test branch 3 times, most recently from 741972c to 911d57e Compare November 11, 2024 12:42
@RolandSherwin RolandSherwin added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 4402dc1 Nov 11, 2024
28 checks passed
@RolandSherwin RolandSherwin deleted the tests-enable_register_test branch November 11, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants