-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests enable register test and windows support #2374
Conversation
502c230
to
365ff32
Compare
b20b3b5
to
b5563b9
Compare
b5563b9
to
216c07a
Compare
645603a
to
0cad33e
Compare
NUM_OF_PUBLIC_FILES = find_number_before_word("file_list.txt", "public") | ||
print("NUM_OF_PUBLIC_FILES:", NUM_OF_PUBLIC_FILES) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not directly use rg
here instead of using Python?
Assuming the file content is something like the one below, then rg should suffice.
❯ echo "1000 public\n2000 private" | rg '\d+\s+public' | awk '{print $1}'
1000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working and python makes it easier to read from the file and make a comparison operation within the one job in windows.
741972c
to
911d57e
Compare
Description
adds register checking in vault CLI testcases.
Related Issue
Fixes #<issue_number> (if applicable).
Type of Change
Please mark the types of changes made in this pull request.
Checklist
Please ensure all of the following tasks have been completed: