chore(test): re-enable can_store_after_restart test #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
encryption_key_from_node_keypair_main
branch
6 times, most recently
from
340da08
to
8a1e4a3
Compare
b-zee
reviewed
Nov 8, 2024
|
|
||
| - name: Run network tests (with encrypt-records) | ||
| timeout-minutes: 5 | ||
| run: cargo test --release --package sn_networking --features="open-metrics, encrypt-records" can_store_after_restart |
There was a problem hiding this comment.
Why do we run this test separately?
There was a problem hiding this comment.
Strangely, I can run this combined with local machine.
However, the CI test always failed, which seems a parallel execution issue causing tests accessing same temp dir ?
Hence have to executed it separately.
maqi
force-pushed
the
encryption_key_from_node_keypair_main
branch
from
8a1e4a3
to
64bfcc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
re-enable can_store_after_restart test