Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launchpad): node actions #2444

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mazzi
Copy link
Contributor

@mazzi mazzi commented Nov 14, 2024

Description

  • Changes on node-manager to be less verbose.
  • Now we can start/stop, add, remove individual nodes. For this we implemented a locking mechanism (semaphore) per node (locked on NodeItem).
  • Added validations when adding nodes regarding amount of nodes and available disk space.
  • Changed footer style and behavior depending on the application state.
  • Some minor error message formatting.
  • Validation of some edge cases like operations without nodes.
  • Changed the legend when upgrading nodes as is difficult to pass the amount of nodes between scenes.

}
}

// FIXME: Can be used if NodeItem implements Copy. Dependencies cannot.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant