Origins + more test suite passing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…...still some issues
…g an Origin...I think the actual mental model is that _rules_ have TrustedOrigins and _facts_ have Origins...so it would be better to avoid storing an Origin inside of TrustedOrigins and conceptually muddying the water
- Implements check all - This required moving any expression evaluation out of combinator - Instead expression evaluation happens in each appropriate `Rule` function
… in and is not quite what biscuit-java is doing, so maybe I need to look at this more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gets all the testsuite tests passing.
However, that is currently using an arena allocator, and if we instead use a GPA we find that we're leaking memory. Need to fix this (and in doing so figure out a good lifetime model)