fix: narrowing conversion in util::compare tests #3342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see what I had while compiling on
linux-aarch64
(Dev Container on MacOS) in the screenshot.clangd
suggests to addstatic_cast<int>
, but I decided against it sincechar
shall not be used with negative values. I'm not 100% certain about that forchar
and negatives are a bit of a tricky thing in the standard.How do you feel about that change? @JohanMabille @Hind-M