Remove fixed assignments #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous commits we replaced some usages of fixed assignments. The only remaining usage was for excluded packages, but since excluded packages are basically negative assertions, we can reuse the (IMO simpler) negative assertion system. As a bonus, we get a reduction in LOC.
aochagavia
force-pushed
the
remove-fixed-assignments
branch
from
22e5357 to
a525ffb
Compare
baszalmstra
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers: this PR assumes that #15 has been merged. Ideally, I'd take my
fix-nested-deps-issuebranch as a base, but then the PR would end up being created in my own repository. Fortunately the whole code is in a single commit, so you can have a look at the last commit's diff (or wait till #15 is merged).