feat(solver)!: Make Problem
use builder pattern
#62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
Problem
input struct (introduced in #54) to use the builder pattern.This allows the
soft_requirements
field to be anIterator
rather than aVec
, which prevents having to unnecessarily clone theSolvableId
s passed tosoft_requirements
(which in some cases could be on the order of hundreds of thousands). Also, this prevents adding a new input argument toSolver::solve
(i.e. a new field inProblem
) from being a breaking change.The C++ bindings remain unchanged and rely on using a simple
resolvo_cpp::Problem
struct as before; they do not expose the builder pattern.