Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new remondis source #2043

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add new remondis source #2043

wants to merge 2 commits into from

Conversation

lal12
Copy link
Contributor

@lal12 lal12 commented May 1, 2024

Add a new remondis source. Remondis is a waste disposal company operating in a bunch of cities. It offers an (old) app for showing the next dates for waste collection. I reverse engineered the app and use it's API.

There might be still some issue left. The API needs a device registration, currently I do this on each init, but this might get us in trouble in the future. So maybe there is a way storing the session somewhere via the HomeAssistant API?

@5ila5
Copy link
Collaborator

5ila5 commented May 3, 2024

Generally LGTM on first sight, but I do not like this many test cases (just keep a few and comment out the rest for debugging)

Do you think people find this source when the're looking for their region? Do you think we should add the regions to the readme using the EXTRA_INFO Variable/Function?

@lal12
Copy link
Contributor Author

lal12 commented May 3, 2024

Will comment them out.

Yeah good point, it doesn't seem to always be obvious that Remondis removes the waste in some cities, they probably act as a sub or in cooperation. But the list I can retrieve from the API also seems to be more than what they actually do, since it gives back no dates. Probably cities they don't service anymore. So the list would contain "false positives".

And btw. it takes 26 requests (~30-60s) to generate that full list of cities.

@5ila5
Copy link
Collaborator

5ila5 commented May 4, 2024

I just noticed you do web request on every update_docu_links.py call. I do not like this, the script is probably called quite a lot and should therefore not make any web requests. Maybe hard-code them with a function to get a new list. You could try to filter out the ones that do not provide any collections and add them to the EXTRA_INFO variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants