Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Add all combinations of element refs and ids for 'create' methods #576

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EotT123
Copy link
Contributor

@EotT123 EotT123 commented Apr 27, 2024

This pull request enhances the create methods for SQL objects by offering more flexibility for handling foreign keys. Previously, users had to choose between object references or IDs, but now they can mix and match as needed. Additionally, identical or nearly identical code has been removed.

Example:

  • previously:
create(Foo fooRef, Bar barRef, ...)
create(Integer fooId, Integer barId, ...)
  • with this PR:
create(Foo fooRef, Bar barRef, ...)
create(Integer fooId, Integer barId, ...)
create(Foo fooRef, Integer barId, ...)
create(Integer fooId, Bar barRef, ...)

@EotT123
Copy link
Contributor Author

EotT123 commented Apr 28, 2024

@rsmckinney I wasn't sure where to put some tests. Feel free to add them in the correct location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant