Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapbase v7.2 Linux fixes #251

Merged

Conversation

Blixibon
Copy link
Member

This is in a separate PR until the fixes are verified.

@Blixibon Blixibon force-pushed the mapbase/feature/v7.2-linux-fixes branch 3 times, most recently from b928512 to 68d4d4a Compare October 25, 2023 18:33
@samisalreadytaken
Copy link

Probably related, this here on Linux ignores the directory (vgui/) escape

V_snprintf( fileName, sizeof( fileName ), "../%s", imageName );

Can be tested with

local panel = vgui.CreatePanel( "ImagePanel", vgui.GetClientDLLRootPanel(), "" );
panel.MakeReadyForUse();
panel.SetVisible( true );
panel.SetPaintEnabled( true );
panel.SetPaintBackgroundEnabled( true );
panel.SetSize( 256, 256 );
panel.SetPos( 0, 0 );
panel.SetImage( "brick/brickfloor001a", false );

@Blixibon Blixibon force-pushed the mapbase/feature/v7.2-linux-fixes branch 2 times, most recently from 6d1934f to b978a4b Compare October 26, 2023 03:44
@Blixibon
Copy link
Member Author

Probably related, this here on Linux ignores the directory (vgui/) escape

V_snprintf( fileName, sizeof( fileName ), "../%s", imageName );

Can be tested with

local panel = vgui.CreatePanel( "ImagePanel", vgui.GetClientDLLRootPanel(), "" );
panel.MakeReadyForUse();
panel.SetVisible( true );
panel.SetPaintEnabled( true );
panel.SetPaintBackgroundEnabled( true );
panel.SetSize( 256, 256 );
panel.SetPos( 0, 0 );
panel.SetImage( "brick/brickfloor001a", false );

I'm not experiencing this issue on my Linux machine. When running the test code, the brick floor texture doesn't render properly due to its shader, but the directory escape successfully navigates to the file.

image

@samisalreadytaken
Copy link

Using brick material (which was a blind example) or a custom material in a custom directory under custom addon mount seems to work indeed. So I don't know what exactly is going on here when the following works only when the materials are put under vgui/. I'm unable to test this further at the moment

Screenshot_2023-10-27_22-56-26

@Blixibon
Copy link
Member Author

That's fine. I'm not in a good position to spend too much time on this myself, so I've opened an issue for it (#252) that can be resolved later.

@Blixibon Blixibon marked this pull request as ready for review October 28, 2023 16:00
@Blixibon Blixibon merged commit ecb58e4 into mapbase-source:develop Nov 10, 2023
4 of 5 checks passed
@Blixibon Blixibon deleted the mapbase/feature/v7.2-linux-fixes branch November 10, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants