Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ai_dynint_always_enabled bypassing misc. criteria on dynamic interactions #284

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Blixibon
Copy link
Member

This fixes an issue in Mapbase v7.2 in which the ai_dynint_always_enabled cvar was overriding dynamic interaction misc. criteria (i.e. keyvalues which use Response System criteria). Some comments associated with this code have also been updated.

Note that no default interactions use misc. criteria and some mods (e.g. E:Z2) override this code anyway.


PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

Copy link

@1upD 1upD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read through these changes a couple of times to understand what's happening here, but I think I understand! The change looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants