Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor internal events API #1266

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Refactor internal events API #1266

merged 6 commits into from
Jul 30, 2024

Conversation

stepankuzmin
Copy link
Contributor

@stepankuzmin stepankuzmin commented Jul 30, 2024 •
edited
Loading

Minor refactoring of the internal event emitting logic.

  • Call map.fire only from the Events class
  • Move store event emitting logic from src/render.js to src/store.js

@stepankuzmin stepankuzmin marked this pull request as ready for review July 30, 2024 14:10
@stepankuzmin stepankuzmin requested a review from a team as a code owner July 30, 2024 14:10
@stepankuzmin stepankuzmin merged commit edf6ecf into main Jul 30, 2024
4 checks passed
@stepankuzmin stepankuzmin deleted the refactor-events branch July 30, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underoot underoot underoot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepankuzmin @underoot