Include fix-it suggestions in deprecation warnings

[1ec5]

Clang now supports an additional argument to the deprecated attribute that results in a fix-it suggestion, similar to the renamed: argument to the @availability() attribute in Swift:

This PR upgrades a couple deprecation warnings to use the new syntax. Some occurrences could not be upgraded, because it looks like fix-it suggestions only work correctly when a member is merely renamed, not moved to another class.

/cc @mapbox/maps-ios

[julianrex]

Thanks!

[friedbunny]

Clang now supports...

@1ec5 do you have any sense of how recent this change is in Xcode? I’m fine with requiring a fairly recent version, but it’d be good to know/document.

[1ec5]

do you have any sense of how recent this change is in Xcode?

I’d always figured that the replacement argument was added for Swift compatibility, since the renamed argument has been part of Swift’s @available attribute for a long time. But apparently replacement was quietly introduced to the availability attribute in Clang 3.9.0, so it would’ve been available as far back as Xcode 7.0. 👴

[friedbunny]

Note that jazzy does not support the replacement argument, so if we want to keep deprecated API in our generated documentation, we should:

• Keep the message argument intact, with a replacement method signature that jazzy can linkify.
• Keep header documentation for the deprecated method, otherwise jazzy will see it as undocumented and ignore it, keeping it out of docs entirely.

---

Jazzy docs for a deprecated property with message and replacement arguments:

Jazzy docs for a deprecated property with just a replacement argument:

[friedbunny]

Opened realm/jazzy#1072 about replacement support.