Use rollup #94
Open
Use rollup #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,10 +11,10 @@ const objectAssign = require('object-assign'); | |||
|
|
|||
| app.set('views', __dirname + '/views'); | |||
| app.set('view engine', 'ejs'); | |||
| app.use(express.static('public')); | |||
| app.use(express.static(__dirname + '/public')); | |||
There was a problem hiding this comment.
any idea where it pulls public from without setting _dirname + '/... ?
I just opened #96 which would conflict with this change, but without making the change mbview was broken for me.
There was a problem hiding this comment.
My guess would express.static looks for "public" in your current working directory.
I couldn't find any docs with a definite answer.
None of
There was a problem hiding this comment.
I couldn't find a single directory with that name, even in node_modules. You're definitely safe to nuke that line.
# in root of repo
docker run -it $(pwd):/root node:12-alpine sh
cd && rm -rf ./node_modules && npm ci && find . -type d -name public
echo $? && exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #56, #42, and #84.
Tests should all pass, but before approving, you should verify the raster layer works as expected. https://github.com/klokantech/vector-tiles-sample has an example raster .mbtiles that you can download, though it's only available at low zoom. I didn't write tests on top of that since the repo is unlicensed (though I did put in a ticket about that).