Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate JSON errors between missing and invalid JSON #10

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Differentiate JSON errors between missing and invalid JSON #10

merged 1 commit into from
Dec 3, 2020

Conversation

jbranigan
Copy link
Contributor

Fixes #3

@jbranigan jbranigan requested a review from yuletide December 1, 2020 20:49
@yuletide
Copy link
Contributor

yuletide commented Dec 3, 2020

This looks like a good refactor but leaves a few issues outstanding:

  • *.jsonl file gets created even if the input json is invalid which could lead to some issues.
  • *.jsonl as input gets converted again into *.jsonll
  • No parsing or validating of input jsonl (this could be pushed to another PR)

As it stands it's difficult to use the --config option with a jsonl based workflow, which would be nice to combine with ogr2ogr for deploys

@jbranigan
Copy link
Contributor Author

Looks like the above comment is referencing #5

@jbranigan jbranigan merged commit f737ec3 into main Dec 3, 2020
@jbranigan jbranigan deleted the inspectJson branch December 3, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuletide yuletide yuletide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add error handling for invalid recipe JSON
2 participants
@jbranigan @yuletide