Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snakemake 8 compatibility #224

Open
tbenavi1 opened this issue Jan 13, 2024 · 2 comments
Open

Snakemake 8 compatibility #224

tbenavi1 opened this issue Jan 13, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@tbenavi1
Copy link

Hello,

I recently updated my version of Snakemake to version 8, and now Verkko doesn't work. Specifically, I get the following error:

snakemake: error: unrecognized arguments: --reason

According to https://github.com/snakemake/snakemake/blob/main/docs/getting_started/migration.rst, "--reason" is deprecated since it is always true now.

Would it be possible to update Verkko to work with Snakemake 8? Thanks so much.

@skoren
Copy link
Member

skoren commented Jan 13, 2024

No plans in the short term (next few months). Snakemake 8 is a major breaking change (like python 3 vs 2) and so, if we support it the users on snakemake 7 would be unable to run verkko. I expect there to still be more users of snakmake 7 than 8 so when we do upgrade I'd hope verkko to detect/use both. For now, I recommend sticking with snakemake 7 and/or using a conda environment to use snakemake 7 for verkko.

@skoren skoren added the enhancement New feature or request label Jan 13, 2024
@skoren skoren added this to the v2.1 milestone Jan 16, 2024
@skoren
Copy link
Member

skoren commented Mar 12, 2024

When running on python3.12, there are errors w/invalid escape characters and finally an error with the constructed resource strings:

/home/runner/work/verkko/verkko/lib/verkko/Snakefiles/c1-buildStore.sm:55: SyntaxWarning: invalid escape sequence '\`'
  # make sure we weren't given compressed read
...
Select jobs to execute...
InputFunctionException in rule buildStore in file /home/runner/work/verkko/verkko/lib/verkko/Snakefiles/c1-buildStore.sm, line 19:
Error:
  KeyError: ' sto _mem_gb '
Wildcards:

Would make sense to address this when we update to Snakemake 8.

@skoren skoren modified the milestones: v2.1, v2.3 Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants