feat: implement skybox texture #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannojg
requested changes
Jul 25, 2024
Comment on lines
65
to
71
| Skybox* skybox = builder.build(*_engine); | ||
| _skybox = References<Skybox>::adoptEngineRef(_engine, skybox, [](std::shared_ptr<Engine> engine, Skybox* skybox) { | ||
| Logger::log(TAG, "Destroying Skybox..."); | ||
| engine->destroy(skybox); | ||
| }); | ||
| _scene->setSkybox(_skybox.get()); | ||
| } |
There was a problem hiding this comment.
We actually also need to destroy / deallocate the texture:
Suggested change
| Skybox* skybox = builder.build(*_engine); | |
| _skybox = References<Skybox>::adoptEngineRef(_engine, skybox, [](std::shared_ptr<Engine> engine, Skybox* skybox) { | |
| Logger::log(TAG, "Destroying Skybox..."); | |
| engine->destroy(skybox); | |
| }); | |
| _scene->setSkybox(_skybox.get()); | |
| } | |
| Skybox* skybox = builder.build(*_engine); | |
| _skybox = References<Skybox>::adoptEngineRef(_engine, skybox, [cubemap](std::shared_ptr<Engine> engine, Skybox* skybox) { | |
| Logger::log(TAG, "Destroying Skybox..."); | |
| engine->destroy(skybox); | |
| engine->destroy(cubemap); | |
| }); | |
| _scene->setSkybox(_skybox.get()); | |
| } |
Note: I think we have some other places in the code base where we miss to do that 😅
There was a problem hiding this comment.
Yeah makes sense, updated the PR 👍
hannojg
approved these changes
Jul 25, 2024
|
Awesome, will be part of the next release, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement skybox texture
Example:
